Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pnpm plugin in Gatsby example. #7916

Merged
merged 2 commits into from Apr 9, 2024
Merged

Remove pnpm plugin in Gatsby example. #7916

merged 2 commits into from Apr 9, 2024

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Apr 8, 2024

Description

Removes the gatsby-plugin-pnpm dependency because:

  1. It doesn't look like it is needed. turbo build and turbo dev still work.
  2. It makes npm installation crash.

Reviewer guide

Note that the only substantive changes are web/package.json and web/gatsby-config.ts. The rest are from npm re-ordering the dependency lists, package manager cleanup, and the lockfile updating.

Closes TURBO-2769

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 4:53pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 4:53pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 4:53pm
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 4:53pm
rust-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 4:53pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 4:53pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 4:53pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 4:53pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 4:53pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 4:53pm

Copy link
Contributor

github-actions bot commented Apr 8, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Apr 8, 2024

🟢 CI successful 🟢

Thanks

@anthonyshew anthonyshew merged commit d9e4583 into main Apr 9, 2024
50 checks passed
@anthonyshew anthonyshew deleted the npm-gatsby-fix branch April 9, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants