Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix external module #7961

Merged
merged 2 commits into from
Apr 15, 2024
Merged

fix external module #7961

merged 2 commits into from
Apr 15, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 15, 2024

Description

With is_esm: true module is not available.

Testing Instructions

Closes PACK-2961

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:41pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:41pm
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:41pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:41pm
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 3:41pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 3:41pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 3:41pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 3:41pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 3:41pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 3:41pm

Copy link
Contributor

github-actions bot commented Apr 15, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Apr 15, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit f2acbc8 into main Apr 15, 2024
45 of 47 checks passed
@sokra sokra deleted the sokra/fix-external-module branch April 15, 2024 15:42
ForsakenHarmony added a commit that referenced this pull request Apr 15, 2024
sokra pushed a commit that referenced this pull request Apr 15, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

With `is_esm: true` `module` is not available.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2961
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

With `is_esm: true` `module` is not available.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2961
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

With `is_esm: true` `module` is not available.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2961
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

With `is_esm: true` `module` is not available.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants