Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove can_be_in_same_chunk #8029

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Apr 24, 2024

This is unused.

Closes PACK-2995

@wbinnssmith wbinnssmith requested a review from a team as a code owner April 24, 2024 00:03
Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 0:23am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 0:23am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 0:23am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 0:23am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 0:23am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 0:23am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 0:23am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 0:23am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 0:23am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 0:23am

Copy link
Contributor

github-actions bot commented Apr 24, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Apr 24, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Contributor

✅ This change can build next-swc

@wbinnssmith wbinnssmith merged commit 9783846 into main Apr 24, 2024
48 of 50 checks passed
@wbinnssmith wbinnssmith deleted the wbinnssmith/no-can_be_in_same_chunk branch April 24, 2024 17:53
kdy1 pushed a commit to vercel/next.js that referenced this pull request Apr 30, 2024
* vercel/turborepo#8020 <!-- Tobias Koppers - Turbopack Tracing: show memory consumption -->
* vercel/turborepo#8029 <!-- Will Binns-Smith - Remove `can_be_in_same_chunk` -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
* vercel/turborepo#8020 <!-- Tobias Koppers - Turbopack Tracing: show memory consumption -->
* vercel/turborepo#8029 <!-- Will Binns-Smith - Remove `can_be_in_same_chunk` -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants