Turbopack: EcmascriptChunkItemContent: add react refresh parameter based on module
#8133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…based on module Rather than reading it from the chunking context, which applies to all modules for a given chunking target, read it from the `EcmascriptOptions` for the module. This ensures that we only make react refresh values available to user code transformed with it. This also: - Removes `EcmascriptChunkingContext`, as it’s no longer necessary - Makes `EcmascriptOptions` a Vc in many more cases Test Plan: Integration tests
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
…ameter based on module
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
…ameter based on module
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
May 13, 2024
Depends on vercel/turbo#8133. See that PR for rationale.
…ameter based on module
…ameter based on module
wbinnssmith
force-pushed
the
wbinnssmith/module-refresh
branch
from
2bd2306
to
156df27
Compare
…ameter based on module
…ameter based on module
bgw
approved these changes
May 14, 2024
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
May 15, 2024
Depends on vercel/turbo#8133. See that PR for rationale.
panteliselef
pushed a commit
to panteliselef/next.js
that referenced
this pull request
May 20, 2024
Depends on vercel/turbo#8133. See that PR for rationale.
| @@ -162,7 +162,7 @@ async fn into_ecmascript_module_asset( | |||
| analyze_types: false, | |||
| }), | |||
| this.transforms, | |||
| Value::new(Default::default()), | |||
| EcmascriptOptions::default().cell(), | |||
There was a problem hiding this comment.
This does kinda need refresh
ForsakenHarmony
added a commit
that referenced
this pull request
Jun 13, 2024
Neosoulink
pushed a commit
to Neosoulink/turbo
that referenced
this pull request
Jun 14, 2024
…based on module (vercel#8133) Rather than reading it from the chunking context, which applies to all modules for a given chunking target, read it from the `EcmascriptOptions` for the module. This ensures that we only make react refresh values available to user code transformed with it. This also: - Removes `EcmascriptChunkingContext`, as it’s no longer necessary - Makes `EcmascriptOptions` a Vc in many more cases Test Plan: Integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than reading it from the chunking context, which applies to all modules for a given chunking target, read it from the
EcmascriptOptionsfor the module. This ensures that we only make react refresh values available to user code transformed with it.This also:
EcmascriptChunkingContext, as it’s no longer necessaryEcmascriptOptionsa Vc in many more casesTest Plan: Integration tests