refactor(turborepo): Rename outputMode to outputLogs in turbo.json
#8149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
NicholasLYang
force-pushed
the
feat/rename-output-logs
branch
from
38ed3d4
to
783fe64
Compare
🟢 Turbopack Benchmark CI successful 🟢Thanks |
NicholasLYang
changed the title
outputMode to outputLogs in turbo.jsonoutputMode to outputLogs in turbo.json
🟢 CI successful 🟢Thanks |
NicholasLYang
force-pushed
the
feat/rename-output-logs
branch
2 times, most recently
from
d2fd7be
to
09c0437
Compare
NicholasLYang
force-pushed
the
feat/rename-output-logs
branch
from
09c0437
to
7700c6d
Compare
NicholasLYang
force-pushed
the
feat/rename-output-logs
branch
from
7700c6d
to
19b5e66
Compare
chris-olszewski
approved these changes
May 16, 2024
docs/public/schema.json
Outdated
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", |
There was a problem hiding this comment.
Minor thing, but if we're going to format a codegen file we should do the formatting as part of the codegen.
There was a problem hiding this comment.
Ah yeah this got accidentally formatted. Reverting
| try { | ||
| packageJSON = readJsonSync(packageJsonPath) as PackageJson; | ||
| } catch (e) { | ||
| // readJSONSync probably failed because the file doesn't exist |
There was a problem hiding this comment.
I think we would want to abort if we are missing/can't read the root package.json
There was a problem hiding this comment.
I copied this logic from the outputs codemod. I'm down to change it though
chris-olszewski
pushed a commit
that referenced
this pull request
May 20, 2024
…on` (#8149) ### Description Changed `outputMode` to `outputLogs` in `turbo.json` to match the flag name. Also wrote a code mod to migrate `turbo.json` config automatically. ### Testing Instructions Existing tests are migrated. Also wrote tests for code mod
chris-olszewski
pushed a commit
that referenced
this pull request
May 22, 2024
…on` (#8149) ### Description Changed `outputMode` to `outputLogs` in `turbo.json` to match the flag name. Also wrote a code mod to migrate `turbo.json` config automatically. ### Testing Instructions Existing tests are migrated. Also wrote tests for code mod
chris-olszewski
pushed a commit
that referenced
this pull request
May 28, 2024
…on` (#8149) ### Description Changed `outputMode` to `outputLogs` in `turbo.json` to match the flag name. Also wrote a code mod to migrate `turbo.json` config automatically. ### Testing Instructions Existing tests are migrated. Also wrote tests for code mod
chris-olszewski
pushed a commit
that referenced
this pull request
May 29, 2024
…on` (#8149) ### Description Changed `outputMode` to `outputLogs` in `turbo.json` to match the flag name. Also wrote a code mod to migrate `turbo.json` config automatically. ### Testing Instructions Existing tests are migrated. Also wrote tests for code mod
chris-olszewski
pushed a commit
that referenced
this pull request
May 31, 2024
…on` (#8149) ### Description Changed `outputMode` to `outputLogs` in `turbo.json` to match the flag name. Also wrote a code mod to migrate `turbo.json` config automatically. ### Testing Instructions Existing tests are migrated. Also wrote tests for code mod
chris-olszewski
pushed a commit
that referenced
this pull request
Jun 4, 2024
…on` (#8149) ### Description Changed `outputMode` to `outputLogs` in `turbo.json` to match the flag name. Also wrote a code mod to migrate `turbo.json` config automatically. ### Testing Instructions Existing tests are migrated. Also wrote tests for code mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
outputModetooutputLogsinturbo.jsonto match the flag name. Also wrote a code mod to migrateturbo.jsonconfig automatically.Testing Instructions
Existing tests are migrated. Also wrote tests for code mod