feat: error on empty package name #8152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
chris-olszewski
force-pushed
the
chrisolszewski/turbo-3030-require-name-field-not-to-be-missing-or-blank-string
branch
from
8765739
to
5c6db28
Compare
codybrouwers
approved these changes
May 15, 2024
🟢 CI successful 🟢Thanks |
chris-olszewski
deleted the
chrisolszewski/turbo-3030-require-name-field-not-to-be-missing-or-blank-string
branch
chris-olszewski
added a commit
that referenced
this pull request
May 20, 2024
### Description We now will error if we encounter a package with a missing or empty package name. This is done in the graph validation step as opposed to construction since we don't want to impose this restriction on `@turbo/repository` users. ### Testing Instructions Added integration test
chris-olszewski
added a commit
that referenced
this pull request
May 22, 2024
### Description We now will error if we encounter a package with a missing or empty package name. This is done in the graph validation step as opposed to construction since we don't want to impose this restriction on `@turbo/repository` users. ### Testing Instructions Added integration test
chris-olszewski
added a commit
that referenced
this pull request
May 28, 2024
### Description We now will error if we encounter a package with a missing or empty package name. This is done in the graph validation step as opposed to construction since we don't want to impose this restriction on `@turbo/repository` users. ### Testing Instructions Added integration test
chris-olszewski
added a commit
that referenced
this pull request
May 29, 2024
### Description We now will error if we encounter a package with a missing or empty package name. This is done in the graph validation step as opposed to construction since we don't want to impose this restriction on `@turbo/repository` users. ### Testing Instructions Added integration test
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
### Description We now will error if we encounter a package with a missing or empty package name. This is done in the graph validation step as opposed to construction since we don't want to impose this restriction on `@turbo/repository` users. ### Testing Instructions Added integration test
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
### Description We now will error if we encounter a package with a missing or empty package name. This is done in the graph validation step as opposed to construction since we don't want to impose this restriction on `@turbo/repository` users. ### Testing Instructions Added integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We now will error if we encounter a package with a missing or empty package name.
This is done in the graph validation step as opposed to construction since we don't want to impose this restriction on
@turbo/repositoryusers.Testing Instructions
Added integration test