feat: all dependencies of root package contribute to global hash #8202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
mehulkar
approved these changes
May 23, 2024
| "dependencies": { | ||
| "util": "*" | ||
| } | ||
| } |
There was a problem hiding this comment.
I can't remember if our integration test fixtures generally use packageManager or not, but that might be useful since I know * has some weird behavior in different npm versions, especially with workspaces.
There was a problem hiding this comment.
I can't remember if our integration test fixtures generally use packageManager or not, but that might be useful since I know * has some weird behavior in different npm versions, especially with workspaces
Good callout. With package manager requirements we now force usage of corepack for all test fixture defaulting to npm if one isn't specified in the fixture. Will open a ticket to make this explicit
| @@ -17,7 +17,7 @@ Check | |||
| Tasks to Run | |||
| build | |||
| Task = build\s* (re) | |||
| Hash = 4047a6e65d7dafef | |||
| Hash = 81a933c332d3f388 | |||
There was a problem hiding this comment.
are all the hashes changing because we're including some kind of "none" value even when there are no root internal deps?
There was a problem hiding this comment.
Yes, since we're changing the Capnproto structure definition the hashing of it is shifting even when there aren't any internal deps.
chris-olszewski
deleted the
chrisolszewski/turbo-2709-root-package-internal-dependencies-treated-same-as-external
branch
chris-olszewski
added a commit
that referenced
this pull request
May 28, 2024
### Description With this PR we will now factor in all root dependency changes. Not just external packages. Internal packages are handled by hashing all of the files contained in the package directory that aren't gitignore'd. This does have performance implications as we can end up globwalking these directories multiple times and hashing the files multiple times if they end up as task inputs. This will be addressed in a future PR. ### Testing Instructions Added integration test that displays new behavior
chris-olszewski
added a commit
that referenced
this pull request
May 29, 2024
### Description With this PR we will now factor in all root dependency changes. Not just external packages. Internal packages are handled by hashing all of the files contained in the package directory that aren't gitignore'd. This does have performance implications as we can end up globwalking these directories multiple times and hashing the files multiple times if they end up as task inputs. This will be addressed in a future PR. ### Testing Instructions Added integration test that displays new behavior
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
### Description With this PR we will now factor in all root dependency changes. Not just external packages. Internal packages are handled by hashing all of the files contained in the package directory that aren't gitignore'd. This does have performance implications as we can end up globwalking these directories multiple times and hashing the files multiple times if they end up as task inputs. This will be addressed in a future PR. ### Testing Instructions Added integration test that displays new behavior
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
### Description With this PR we will now factor in all root dependency changes. Not just external packages. Internal packages are handled by hashing all of the files contained in the package directory that aren't gitignore'd. This does have performance implications as we can end up globwalking these directories multiple times and hashing the files multiple times if they end up as task inputs. This will be addressed in a future PR. ### Testing Instructions Added integration test that displays new behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR we will now factor in all root dependency changes. Not just external packages.
Internal packages are handled by hashing all of the files contained in the package directory that aren't gitignore'd.
This does have performance implications as we can end up globwalking these directories multiple times and hashing the files multiple times if they end up as task inputs. This will be addressed in a future PR.
Testing Instructions
Added integration test that displays new behavior