Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(@turbo/utils): update tests/fixtures to use tasks key #8225

Merged
merged 2 commits into from
May 29, 2024
Merged

chore(@turbo/utils): update tests/fixtures to use tasks key #8225

merged 2 commits into from
May 29, 2024

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented May 28, 2024 •
edited
Loading

I've confirmed that turbo test -F @turbo/utils passes on this branch

@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 1:19am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 1:19am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:19am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:19am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:19am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:19am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:19am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:19am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:19am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 1:19am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 28, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 28, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@mehulkar mehulkar force-pushed the mehulkar/turbo-3228-update-turbo-utils branch from 3ebf26f to 7e84350 Compare May 28, 2024 17:23
@mehulkar mehulkar changed the base branch from turborepo_2 to mk/dogfood-new-canary-in-ci May 28, 2024 17:24
@github-actions GitHub Actions
Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `lightningcss`.
    ... required by package `turbopack-ecmascript-plugins v0.1.0 (https://github.com/vercel/turbo?rev=fda99d72f022403c0a3fed8553f37bbe363d4dda#2faf1cbd)`
    ... which satisfies git dependency `turbopack-ecmascript-plugins` of package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=fda99d72f022403c0a3fed8553f37bbe363d4dda#2faf1cbd)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^1.0.0-alpha.57` are: 1.0.0-alpha.57

all possible versions conflict with previously selected packages.

  previously selected package `lightningcss v1.0.0-alpha.56`
    ... which satisfies dependency `lightningcss = "^1.0.0-alpha.55"` (locked to 1.0.0-alpha.56) of package `lightningcss-napi v0.2.0`
    ... which satisfies dependency `lightningcss-napi = "^0.2.0"` (locked to 0.2.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`

failed to select a version for `lightningcss` which could resolve this conflict

See job summary for details

@mehulkar mehulkar force-pushed the mk/dogfood-new-canary-in-ci branch from 1b297ab to 4deb791 Compare May 28, 2024 17:30
@mehulkar mehulkar force-pushed the mehulkar/turbo-3228-update-turbo-utils branch from 7e84350 to ad34330 Compare May 28, 2024 17:40
@mehulkar mehulkar force-pushed the mk/dogfood-new-canary-in-ci branch from 4deb791 to 90b8237 Compare May 28, 2024 17:49
@mehulkar mehulkar force-pushed the mehulkar/turbo-3228-update-turbo-utils branch from ad34330 to 589bd33 Compare May 28, 2024 18:57
@mehulkar mehulkar changed the base branch from mk/dogfood-new-canary-in-ci to turborepo_2 May 28, 2024 19:00
@mehulkar mehulkar marked this pull request as ready for review May 28, 2024 19:35
@mehulkar mehulkar requested a review from a team as a code owner May 28, 2024 19:35
chris-olszewski
chris-olszewski approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PR title is a little misleading since the updates are to use tasks key.

@mehulkar mehulkar changed the title chore(@turbo/utils): update tests/fixtures to use pipeline key chore(@turbo/utils): update tests/fixtures to use tasks key May 29, 2024
@mehulkar mehulkar merged commit 75abd54 into turborepo_2 May 29, 2024
55 checks passed
@mehulkar mehulkar deleted the mehulkar/turbo-3228-update-turbo-utils branch May 29, 2024 01:21
chris-olszewski pushed a commit that referenced this pull request May 29, 2024
@mehulkar @chris-olszewski
chore(@turbo/utils): update tests/fixtures to use tasks key (#8225)
4072884
chris-olszewski pushed a commit that referenced this pull request May 31, 2024
@mehulkar @chris-olszewski
chore(@turbo/utils): update tests/fixtures to use tasks key (#8225)
2ac99ea
chris-olszewski pushed a commit that referenced this pull request Jun 4, 2024
@mehulkar @chris-olszewski
chore(@turbo/utils): update tests/fixtures to use tasks key (#8225)
935d996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@Zertsov Zertsov Awaiting requested review from Zertsov Zertsov is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
created-by: turborepo owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mehulkar @chris-olszewski