Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(turborepo): fancy package.json errors #8299

Merged
merged 11 commits into from
Jul 19, 2024
Merged

feature(turborepo): fancy package.json errors #8299

merged 11 commits into from
Jul 19, 2024

Conversation

NicholasLYang
Copy link
Contributor

@NicholasLYang NicholasLYang commented Jun 4, 2024 •
edited
Loading

Description

More fancy errors! Since we now have span info for package.json files, we can produce errors pointing to locations in package.json.

Testing Instructions

@vercel Vercel
Copy link

vercel bot commented Jun 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 3:49pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 3:49pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 3:49pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 3:49pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 3:49pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 3:49pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 3:49pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 3:49pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 3:49pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 3:49pm

@NicholasLYang Graphite App
Copy link
Contributor Author

NicholasLYang commented Jun 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NicholasLYang and the rest of your teammates on Graphite Graphite

@NicholasLYang NicholasLYang changed the title Added package.json errors using biome span info feature(turborepo): fancy package.json errors Jun 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@NicholasLYang NicholasLYang force-pushed the nicholasyang/biome-package-json branch from 5e41591 to b0c8574 Compare June 17, 2024 19:30
@NicholasLYang NicholasLYang force-pushed the nicholasyang/package-json-errors branch from c0fd54d to 2b3d13f Compare June 17, 2024 19:41
@NicholasLYang NicholasLYang force-pushed the nicholasyang/biome-package-json branch 3 times, most recently from 5e25077 to 792c898 Compare June 20, 2024 17:03
Base automatically changed from nicholasyang/biome-package-json to main June 20, 2024 19:18
@NicholasLYang NicholasLYang force-pushed the nicholasyang/package-json-errors branch from 2b3d13f to 009574a Compare June 20, 2024 19:24
@NicholasLYang NicholasLYang marked this pull request as ready for review June 20, 2024 19:25
@NicholasLYang NicholasLYang requested a review from a team as a code owner June 20, 2024 19:25
dimitropoulos
dimitropoulos approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@dimitropoulos dimitropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much improved! this raised the question of how we want to handle nested package.json errors (i.e. not from the root package.json) which don't take the path of getting these nice errors, but sounds like we'll follow up with that in the future.

@NicholasLYang NicholasLYang force-pushed the nicholasyang/package-json-errors branch from c4a93a8 to b48e318 Compare July 17, 2024 18:11
@NicholasLYang NicholasLYang enabled auto-merge (squash) July 17, 2024 18:14
@NicholasLYang NicholasLYang force-pushed the nicholasyang/package-json-errors branch from 7810bbe to 653b34e Compare July 19, 2024 15:47
@ijjk
Copy link
Member

ijjk commented Jul 19, 2024

Allow CI Workflow Run

  • approve CI run for commit: 653b34e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@NicholasLYang NicholasLYang merged commit 5a68e3a into main Jul 19, 2024
64 of 65 checks passed
@NicholasLYang NicholasLYang deleted the nicholasyang/package-json-errors branch July 19, 2024 16:33
@samcx samcx mentioned this pull request Jul 22, 2024
Merged
samcx added a commit to vercel/next.js that referenced this pull request Jul 28, 2024
@samcx
chore: bump turbo to 2.0.9 (#68046)
cf5b535 
## Why?

- Better package.json errors via
[#8299](vercel/turbo#8299),
[#8753](vercel/turbo#8753)
- Successful
[build-and-deploy](https://github.com/vercel/next.js/actions/runs/10127839598)
run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitropoulos dimitropoulos dimitropoulos approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
created-by: turborepo owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NicholasLYang @ijjk @dimitropoulos