Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GitLab VendorBehavior #8300

Merged
merged 13 commits into from
Jun 18, 2024

Conversation

cymruu
Copy link
Contributor

@cymruu cymruu commented Jun 4, 2024

Description

Adds a GitLab service VendorBehavior, so that logs are aggregated into groups.

This was initially part of #6188. However, due to the special treatment required for the timestamps indicating the start and end of log groups, a decision was made to remove it from the initial task's scope.

Testing Instructions

  1. build turborepo binary
  2. push an example monorepo to GitLab
  3. run some turbo tasks in GitLab CI
  4. check if logs are grouped into sections

@cymruu cymruu requested a review from a team as a code owner June 4, 2024 20:18
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Jun 4, 2024
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 9:45pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 9:45pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 9:45pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 9:45pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 9:45pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 9:45pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 9:45pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 9:45pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 9:45pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 9:45pm

Copy link

vercel bot commented Jun 4, 2024

@cymruu is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Jun 4, 2024

Allow CI Workflow Run

  • approve CI run for commit: 5fc8959

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR! Sorry it took a bit to review.

Copy link
Contributor

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final lint change

crates/turborepo-ci/src/vendors.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants