Repo Updates for OSS #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/3y7djo9nPGDTYNMwjE81yvPc2JNB |
sokra
added a commit
that referenced
this pull request
Oct 25, 2022
documentation, formating, cleanup
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
Since we used to build the HTML using our own `<Document>` component, we were previously adding a data-turbopack-chunk-id attribute to our `<link>` tags to reconcile chunk paths with their chunk ids when initializing HMR. However, Next.js is now responsible for building the HTML, and it has no such mechanism. **NOTE:** HMR is currently broken for non-Next-SSR rendering (HtmlAsset). This PR does not fix that.
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
Since we used to build the HTML using our own `<Document>` component, we were previously adding a data-turbopack-chunk-id attribute to our `<link>` tags to reconcile chunk paths with their chunk ids when initializing HMR. However, Next.js is now responsible for building the HTML, and it has no such mechanism. **NOTE:** HMR is currently broken for non-Next-SSR rendering (HtmlAsset). This PR does not fix that.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Since we used to build the HTML using our own `<Document>` component, we were previously adding a data-turbopack-chunk-id attribute to our `<link>` tags to reconcile chunk paths with their chunk ids when initializing HMR. However, Next.js is now responsible for building the HTML, and it has no such mechanism. **NOTE:** HMR is currently broken for non-Next-SSR rendering (HtmlAsset). This PR does not fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21