fix(turbopack): add no-op resolveAbsolutePath to browser runtime
#8549
+29
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
ForsakenHarmony
force-pushed
the
hrmny/pack-3095-browser-resolve-absolute-path
branch
from
1a084c1
to
1c3c3d7
Compare
sokra
reviewed
Jun 20, 2024
Comment on lines
+395
to
+398
| if (modulePath) { | ||
| return modulePath; | ||
| } | ||
| return "/ROOT/"; |
There was a problem hiding this comment.
Shoudn't it return something like:
Suggested change
| if (modulePath) { | |
| return modulePath; | |
| } | |
| return "/ROOT/"; | |
| return `/ROOT/${modulePath || ''}`; |
There was a problem hiding this comment.
Yes, initially thought it was added by codegen
sokra
requested changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reading
import.meta.hotshould work in the browser, it can just return a/ROOT/...path.Fixes vercel/next.js#66005