fix(turborepo): add berry support for built meta when pruning #8550
Conversation
turbo-orchestrator
bot
added
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
@vinnymac is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for the PR! I think this looks good to me, but I'll be doing some additional testing just because |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
| @@ -163,6 +163,9 @@ where | |||
|
|
|||
| for (dependency, meta) in metadata { | |||
| let dependency = dependency.as_ref(); | |||
| if meta.built.unwrap_or_default() { | |||
There was a problem hiding this comment.
Sorry I missed this, I believe this logic needs to be changed so we only include built if it is present. add_line will also need to be updated to be able to write both true and false.
| if meta.built.unwrap_or_default() { | |
| if meta.built.unwrap_or_default() { |
There was a problem hiding this comment.
I updated it so all three dependencyMeta settings support true and false. And check if they are present before adding the lines.
Let me know if you find any more 🐛 s. 🙇🏼♂️
| if let Some(optional) = meta.optional { | ||
| add_line(dependency, "optional", optional); | ||
| } | ||
| if let Some(unplugged) = meta.unplugged { |
There was a problem hiding this comment.
After updating this for built, I assumed someone may set optional or unplugged to false, and then that too would become an issue.
Description
Add support for yarn berry built option for dependencies meta to
turbo prune.Without this change,
yarn install --immutablefails becausebuiltis added after turbo accidentally removes it, triggering the following error.Testing Instructions
built: false.yarn install --immutableon that small lockfile