Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(turbo): add TMP and TEMP variables to pass through #8803

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

cahilfoley
Copy link
Contributor

Description

This is required so node scripts and other tools can detect the correct location to create temporary files and folders. In particular it's required for the Node.js os.tmpdir() function.

Testing Instructions

Create an app or package task that access either the TMP or TEMP environment variables and observe that they are passed through correctly.

This should hopefully resolve this issue #8802

## Description
This is required so node scripts and other tools can detect the correct location to create temporary files and folders. In particular it's required for the Node.js [os.tmpdir()](https://nodejs.org/api/os.html#ostmpdir) function.
@cahilfoley cahilfoley requested a review from a team as a code owner July 22, 2024 03:24
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Jul 22, 2024
Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 3:08pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 3:08pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 3:08pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 3:08pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 3:08pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 3:08pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 3:08pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 3:08pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 3:08pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 3:08pm

Copy link

vercel bot commented Jul 22, 2024

@cahilfoley is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Jul 22, 2024

Allow CI Workflow Run

  • approve CI run for commit: fe28ea5

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants