Don't impl PartialEq/Eq for SharedReference and wrapper types #8815
+73
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
Logs
See job summary for details |
|
sokra
reviewed
Jul 23, 2024
| fn hash<H: std::hash::Hasher>(&self, state: &mut H) { | ||
| self.inner.hash(state); | ||
| self.inner.1.as_ptr().hash(state); |
There was a problem hiding this comment.
Maybe implement ptr_hash on SharedReference
sokra
reviewed
Jul 23, 2024
Comment on lines
+32
to
+33
| this.iter() | ||
| .all(|(key, value)| other.get(key).map_or(false, |v| value.ptr_eq(v))) |
There was a problem hiding this comment.
Order should matter here. You can use zip() instead. That's also more performant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Where feasible (I gave up on
TransientInstance<T>) don't implPartialEq,EqorHashforSharedReferenceor it's various wrapper types.These were previously using identity for equality, but I strongly prefer a more explicit approach (akin to
Arc::ptr_eq) when using identity equality because it can lead to caching bugs where the caller didn't realize and expected value equality.Testing Instructions
This breaks the nextjs build and would require a companion nextjs PR if we wanted to go forward with this.