Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starter project fails with yarn pnp mode #1066

Closed
magnattic opened this issue Apr 18, 2022 · 1 comment
Closed

Starter project fails with yarn pnp mode #1066

magnattic opened this issue Apr 18, 2022 · 1 comment

Comments

@magnattic
Copy link

magnattic commented Apr 18, 2022

What version of Turborepo are you using?

1.2.4

What package manager are you using / does the bug impact?

Yarn v3 (pnp mode)

What operating system are you using?

Windows with WSL2/Ubuntu

Describe the Bug

According to #693 yarn 3 in pnp mode should work now.

However, when I create a brand new turborepo project and switch to pnp mode, the build fails with a couple of errors:

build ouput
> yarn build
• Packages in scope: config, docs, tsconfig, ui, web
• Running build in 5 packages
docs:build: cache miss, executing e865bc89066cf472
web:build: cache miss, executing 6d2c774721ec3ba9
web:build: info  - Checking validity of types...
docs:build: info  - Checking validity of types...
docs:build: error - ESLint: Failed to load config "next" to extend from. Referenced from: /home/magnattic/code/poc-turbo/apps/docs/.eslintrc.js
web:build: error - ESLint: Failed to load config "next" to extend from. Referenced from: /home/magnattic/code/poc-turbo/apps/web/.eslintrc.js
web:build: info  - Creating an optimized production build...
docs:build: info  - Creating an optimized production build...
docs:build: Failed to compile.
docs:build:
docs:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/client/index.js
docs:build: Error: Failed to read source code from /home/magnattic/code/poc-turbo/.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/client/index.js
docs:build:
docs:build: Caused by:
docs:build:     No such file or directory (os error 2)
docs:build:
docs:build: Import trace for requested module:
docs:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/client/next.js
docs:build:
docs:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/shared/lib/head.js
docs:build: Error: Failed to read source code from /home/magnattic/code/poc-turbo/.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/shared/lib/head.js
docs:build:
docs:build: Caused by:
docs:build:     No such file or directory (os error 2)
docs:build:
docs:build: Import trace for requested module:
docs:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/pages/_error.js
docs:build:
docs:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/shared/lib/router/router.js
docs:build: Error: Failed to read source code from /home/magnattic/code/poc-turbo/.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/shared/lib/router/router.js
docs:build:
docs:build: Caused by:
docs:build:     No such file or directory (os error 2)
docs:build:
docs:build: Import trace for requested module:
docs:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/client/router.js
docs:build:
docs:build: ../../packages/ui/Button.tsx
docs:build: Module not found: Can't resolve 'react/jsx-runtime' in '/home/magnattic/code/poc-turbo/packages/ui'
docs:build:
docs:build: Import trace for requested module:
docs:build: ../../packages/ui/index.tsx
docs:build: ./pages/index.tsx
docs:build:
docs:build: ../../packages/ui/Button.tsx
docs:build: Module not found: Can't resolve 'react' in '/home/magnattic/code/poc-turbo/packages/ui'
docs:build:
docs:build: Import trace for requested module:
docs:build: ../../packages/ui/index.tsx
docs:build: ./pages/index.tsx
docs:build:
docs:build:
docs:build: > Build failed because of webpack errors
web:build: Failed to compile.
web:build:
web:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/client/index.js
web:build: Error: Failed to read source code from /home/magnattic/code/poc-turbo/.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/client/index.js
web:build:
web:build: Caused by:
web:build:     No such file or directory (os error 2)
web:build:
web:build: Import trace for requested module:
web:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/client/next.js
web:build:
web:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/shared/lib/head.js
web:build: Error: Failed to read source code from /home/magnattic/code/poc-turbo/.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/shared/lib/head.js
web:build:
web:build: Caused by:
web:build:     No such file or directory (os error 2)
web:build:
web:build: Import trace for requested module:
web:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/pages/_error.js
web:build:
web:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/shared/lib/router/router.js
web:build: Error: Failed to read source code from /home/magnattic/code/poc-turbo/.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/shared/lib/router/router.js
web:build:
web:build: Caused by:
web:build:     No such file or directory (os error 2)
web:build:
web:build: Import trace for requested module:
web:build: ../../.yarn/__virtual__/next-virtual-bf60baa973/0/cache/next-npm-12.0.8-aa55acca00-947f0295aa.zip/node_modules/next/dist/client/router.js
web:build:
web:build: ../../packages/ui/Button.tsx
web:build: Module not found: Can't resolve 'react/jsx-runtime' in '/home/magnattic/code/poc-turbo/packages/ui'
web:build:
web:build: Import trace for requested module:
web:build: ../../packages/ui/index.tsx
web:build: ./pages/index.tsx
web:build:
web:build: ../../packages/ui/Button.tsx
web:build: Module not found: Can't resolve 'react' in '/home/magnattic/code/poc-turbo/packages/ui'
web:build:
web:build: Import trace for requested module:
web:build: ../../packages/ui/index.tsx
web:build: ./pages/index.tsx
web:build:
web:build:
web:build: > Build failed because of webpack errors
docs:build: Error: command finished with error: command (apps/docs) yarn run build exited (1)

Expected Behavior

No errors and a build that succeeds out of the box.

To Reproduce

Run the following:

  • npx create-turbo@latest (select 'yarn')
  • cd my-turborepo
  • yarn set version stable
  • edit .yarnrc.yml and add nodeLinker: pnp
  • yarn install
  • yarn run build
@nathanhammond
Copy link
Contributor

We currently have no plans to support Yarn 3 (Berry) in PNP mode. It was never supported (in spite of the earlier mention in this thread). The path to support for this is one of two options:

  1. Open a PR. We will accept this work if done by the community and maintain it in perpetuity.
  2. We're corporate-sponsored OSS. If your company needs this and is a Vercel Enterprise customer reach out through your account manager and we can start a discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants