-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for yarn berry v3 with PnP as install strategy #693
Comments
Can we get clarification on what support needs to be added here? I have tested locally by commenting out the It looks like maybe the bin script also needs work, but that can be fixed by changing: const turboLibDir = path.dirname(require.resolve("turbo")); to reference package.json since the turbo package doesn't have a "main" export and the above resolve fails: const turboLibDir = path.dirname(require.resolve("turbo/package.json")); |
Regarding #693 (comment) I believe this at least partially addresses Issue: #693, but the scope of the issue is unclear. More specifically this removes the general check for yarn pnp and moves it into the prune command instead as this is the part that likely has remaining issues with pnp since nothing else that I'm aware of needs to know about `node_modules`. This PR builds off of #795, as otherwise you can't even run turbo to be able to hit the previous nodeLinker checks. Let me know if you would like me to change things around so that it is more explicitly enabling for the run task as opposed to enabling for all but prune.
This is now available in |
Great news! Thanks so much for working on this. |
It seems that only the node-module linker from yarn is supported (
|
Would be really nice if nodeLinker: pnp could be supported. |
@jaredpalmer, As @thebanjomatic explained, looks like the |
Hello everyone! Is this continued at #1066 ? Thanks! |
We currently have no plans to support Yarn 3 (Berry) in PNP mode. It was never supported (in spite of the earlier mention in this thread). The path to support for this is one of two options:
|
@nathanhammond |
Yarn PNP is de facto standard for monorepos. How is it possible that it's not supported? |
Describe the feature you'd like to request
I would like to be able to use this tool with yarn berry v2/v3 as my package manager and Plug'n'Play as the install strategy.
Describe the solution you'd like
I would like the tool to support Plug'n'Play as the install strategy when using yarn berry.
Describe alternatives you've considered
Using another install strategy.
The text was updated successfully, but these errors were encountered: