Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can't read yellow on a white background #3799

Closed
jtlapp opened this issue Feb 14, 2023 · 2 comments · Fixed by #3810
Closed

I can't read yellow on a white background #3799

jtlapp opened this issue Feb 14, 2023 · 2 comments · Fixed by #3810
Labels
area: logging Improvements to logging kind: bug Something isn't working

Comments

@jtlapp
Copy link

jtlapp commented Feb 14, 2023

What version of Turborepo are you using?

1.7.4

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Mac

Describe the Bug

I am unable to read yellow text on a white background. Here's an example, but mind you, readability will depend in part on your monitor.

Screen Shot 2023-02-14 at 08 20 49

Copying and pasting to an editor reveals the text: "No tasks were executed as part of this run."

Expected Behavior

I should be able read Turborepo output.

To Reproduce

Add a task to turbo.json that doesn't correspond to any package.json scripts, and run this task.

Reproduction Repo

No response

@jtlapp jtlapp added area: turborepo kind: bug Something isn't working labels Feb 14, 2023
@mehulkar
Copy link
Contributor

The Warning color is hardcoded to Yellow here:
https://github.com/vercel/turbo/blob/74f9f6eebc1c5d8323643313280f6d0d3fbcecbd/cli/internal/ui/ui.go#L118

I'm not sure of standard practice here for color contrast, since the background of your terminal could be any color. Maybe we could revisit this and take the background into account somehow.

@mehulkar mehulkar added the area: logging Improvements to logging label Feb 14, 2023
@jtlapp
Copy link
Author

jtlapp commented Feb 14, 2023

It ought to at least be presentable on white and black. Any other color is non-standard, buyer beware.

I'm not fond of the colored text anyway. I've commented on another open issue about having once been left typing black text on a black background, making it invisible. I had to close the terminal window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: logging Improvements to logging kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants