switch e2e tests to use corepack #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A quick and dirty switch to use corepack for managing package managers for our e2e tests. A few things to note: - Running these tests on a local machine will enable corepack on that machine, this could be undesired for some devs. - I found that it is necessary to forcibly add the corepack install dir to the top of $PATH in case a dev has a package manager installed elsewhere that would take priority.
chris-olszewski
requested review from
jaredpalmer,
gsoltis,
gaspar09,
nathanhammond,
tknickman and
mehulkar
as code owners
|
@chris-olszewski is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
chris-olszewski
force-pushed
the
e2e_corepack
branch
from
9b9cf1d
to
554846e
Compare
jaredpalmer
approved these changes
Aug 5, 2022
chris-olszewski
force-pushed
the
e2e_corepack
branch
14 times, most recently
from
3f2db08
to
5a026ad
Compare
tknickman
reviewed
Aug 8, 2022
| # higher we can remove the second install command. | ||
| run: pnpm install; echo $PATH; npm install --force --global corepack@latest | ||
|
|
||
| - name: Debug CI @donotmerge |
There was a problem hiding this comment.
No, this will be taken out. I've been resorting to print debugging for some issues that only show up on Windows CI 🙃
chris-olszewski
force-pushed
the
e2e_corepack
branch
2 times, most recently
from
10157ca
to
c50aa15
Compare
chris-olszewski
force-pushed
the
e2e_corepack
branch
from
70d7356
to
782c1b3
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 8, 2022
An action I was using to debug CI jobs in #1632 accidentally got merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick and dirty switch to use corepack for managing package managers for our e2e tests.
A few things to note:
At the moment this is only useful for the Yarn/Berry split, but it would simplify #1612 which adds pnpm6 to e2e tests quite a bit.