Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bounded parallelization when saving cache #723

Merged
merged 17 commits into from Mar 2, 2022

Conversation

glesperance
Copy link
Contributor

@glesperance glesperance commented Feb 11, 2022

Fix for #711 (discussion #709).

Bounded cache saving parallelization to runtime.NumCPU() which now gives us the maximum number of effective threads while staying under the OS limit of max processes count.

Cheers 🎉

@vercel
Copy link

vercel bot commented Feb 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/6KYpyJf7wDUM1jM4BhPZqvXyByAh
✅ Preview: https://turbo-site-git-fork-glesperance-fix-runtime-too-many-threads.vercel.sh

[Deployment for 3a4379d failed]

Copy link
Contributor

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a much better approach!

I think the next step is to figure out how to thread a configuration value through to this point so that it can be customized.

cli/internal/cache/cache_fs.go Outdated Show resolved Hide resolved
@glesperance
Copy link
Contributor Author

@gsoltis any chance we can get this merged without the configurable option? I understand a parameter would be good, but I feel it's best we fix the issue first.

@jaredpalmer
Copy link
Contributor

Cutting now

@jaredpalmer jaredpalmer changed the title Fix(cli): bounded parallelization when saving cache fix(cli): bounded parallelization when saving cache Feb 25, 2022
@jaredpalmer jaredpalmer changed the title fix(cli): bounded parallelization when saving cache fix: bounded parallelization when saving cache Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants