-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy command does not exit when it shows an error #1196
Comments
We are investigating. Giving this priority even though it's in canary |
@rauchg, I tried to debug the issue myself with the help of https://www.npmjs.com/package/why-is-node-running, but I only found out that the ,responseError‘ promise still seems to be around even after the error messages have appeared. But as this is my first time debugging the node async loop, even that might not be a correct finding ;) |
@rauchg, maybe you can point me to some node debugging resources (articles/tools?) that could help me helping you? :) |
@rauchg, meanwhile: whatever you did (or are doing) within https://github.com/zeit/now-cli/tree/better-list, it fixes this bug :) |
Thank you so much for the effort you have put into this issue! 😊 However, since we completely re-worked the entire codebase of Now CLI and this issue does not apply to the new code anymore, I'm closing it now. You can read more about our biggest release yet here: https://zeit.co/blog/now-2 |
While working on a solution for #1010 I discovered that the current Canary release (
11.0.0-canary.30
) does not exit after showing a deploy error.I just set up a directory with a single file that exceeds my current plan (> 1 MB) and tried to deploy it. The (to be improved) "File size limit exceeded" error occurs, but the process is still alive. I had to break out of i manually.
This behaviour does not appear on the stable version (
10.1.6
).The text was updated successfully, but these errors were encountered: