Improve error clarity when a certain file is too large

[rauchg]

#992 (comment)

[williamolojede]

This issue has been open up for a while, I'll like to take a shot at it😀

[williamolojede]

@rauchg you said in #992 that the error message will be improved, what will be a good/appropriate error message?

[rauchg]

Error! The file "x" exceeds your plan's limit ymb

Let me know if you have enough information in the error object to render the limit. Otherwise, I can make sure we give you something like this:

{
   "error": {
      "code": "max_filesize_exceeded",
      "max": 1235931851
   }
}

By using the bytes module we can also render it in a human readable-way.

Thanks a lot @williamolojede

[williamolojede]

@rauchg Thanks for you previous response and I apologize for the late response. I tried recreating the issue by deploying a node app with an mp3(> 3mb) file included since that exceeds the single file limit for OSS plan but i don't seem to get any error and the upload and deployment is successful. Adding a bigger file(>10mb) doesn't seem to cause any issue too and it syncs the new file successfully, Now I'm confused, I'm i missing something?

Also is it possible to use my copy of the now-cli repo to run now commands so I see my proposed fix in action?

[timneutkens]

@williamolojede

Also is it possible to use my copy of the now-cli repo to run now commands so I see my proposed fix in action?

To link the now command to your local clone:
npm run link

To build the files as you make changes:
npm run dev

[williamolojede]

@timneutkens thanks man,

I tried recreating the issue by deploying a node app with an mp3(> 3mb) file included since that exceeds the single file limit for OSS plan but i don't seem to get any error and the upload and deployment is successful. Adding a bigger file(>10mb) doesn't seem to cause any issue too and it syncs the new file successfully, Now I'm confused, I'm i missing something?

do you have an idea of what is going on with that?

[williamolojede]

@rauchg I'm hoping to get a response from you soon

[Aneeshmysore]

@rauchg @williamolojede is this an issue that is still open to be worked on?

[OlliV]

There are two possibilities, either the file was already uploaded before or there was an issue on our server side.

Here is how the error object is formatted:

{
  error: {
    message,
    code: 'size_limit_exceeded',
    sizeLimit
  }
}

[leo]

We should render a better error here!