Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve alias UX #68

Closed
flybayer opened this issue Oct 8, 2016 · 5 comments
Closed

Improve alias UX #68

flybayer opened this issue Oct 8, 2016 · 5 comments
Labels
triaged: feature request Issue or PR has been reviewed by a maintainer and work is being tracked

Comments

@flybayer
Copy link
Contributor

flybayer commented Oct 8, 2016

I know there's been some discussion in zeit.chat about this, but I thought it'd be good to open a issue for further discussion.

I'm not sure of the best solution to improve the aliases experience, but here's some ideas for consideration:

Ability to alias multiple domains at once

I'd like to do this:

now alias <ID> domain.com www.domain.com

instead of this:

now alias <ID> domain.com 
now alias <ID> www.domain.com

Ability to define domain aliases in package.json or some other file

I'd like to do this:

now alias

and have the latest deployment automatically aliased to one or more configured domains

Alternatively, it could be:

now alias <ID>

which would be easy to do since the deployment url is automatically copied to the clipboard.

I know now-realias does something like this, but I think this should be apart of the official client :)

@remy
Copy link
Contributor

remy commented Oct 22, 2016

I'm making progress on this at the moment.

My focus is making now alias work by reading the package.json's config.alias property, and linking it to the last deployment for the name.

@slorber
Copy link

slorber commented Oct 25, 2016

+1 for linking to last deployment

Would be nice to be able to define "domain aliases" and do "now alias latest dev,staging,prod"

lukemorton added a commit to lukemorton/now-cli that referenced this issue Jan 7, 2017
A small superficial change to bin/now-deploy.js so that we can specify one or more aliases whilst deploying.

**Examples**

```
now --alias a.com
now --alias a.com --alias b.com
```

We handle the alias assignment serially so that the CLI output makes sense.

**Some thoughts**

 - I’m hoping this PR can close out vercel#172
 - Aware this PR likely affects vercel#68
 - This is a superficial change, really we should update the lib/alias.js to handle multiple domains
leo pushed a commit that referenced this issue Jan 7, 2017
A small superficial change to bin/now-deploy.js so that we can specify one or more aliases whilst deploying.

**Examples**

```
now --alias a.com
now --alias a.com --alias b.com
```

We handle the alias assignment serially so that the CLI output makes sense.

**Some thoughts**

 - I’m hoping this PR can close out #172
 - Aware this PR likely affects #68
 - This is a superficial change, really we should update the lib/alias.js to handle multiple domains
@lukemorton
Copy link
Contributor

Seeing as we now support now --alias a.com --alias b.com, what should supporting multiple domains for now alias look like?

now alias <ID> domain.com www.domain.com

This makes their APIs a little inconsistent. Does this matter?

@slorber
Copy link

slorber commented Feb 2, 2017

Hey, would it be possible to allow using a custom domain alias as source?

now alias set staging.domain.com prod.domain.com

It shouldn't be very hard, just requiring to resolve the domain alias to its deploymentId upfront, and it would be very useful for me :)

@Qix- Qix- added the triage label Nov 10, 2017
@leo leo added help wanted triaged: feature request Issue or PR has been reviewed by a maintainer and work is being tracked and removed good for beginners labels Nov 13, 2018
@TooTallNate
Copy link
Member

Closing this because now alias and now alias <id> have worked for a long time. But more importantly, I think that Automatic Aliasing supersedes this feature request since now alias (with no arguments) is more or less deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged: feature request Issue or PR has been reviewed by a maintainer and work is being tracked
Projects
None yet
Development

No branches or pull requests

7 participants