Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] add maxDuration config support for vc node deployments #10028

Merged
merged 9 commits into from Jun 5, 2023

Conversation

ecklf
Copy link
Member

@ecklf ecklf commented May 26, 2023

This PR enables specifying maxDuration in config for node vc deployments.

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2023

🦋 Changeset detected

Latest commit: a84559c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@vercel/node Minor
vercel Patch
@vercel/gatsby-plugin-vercel-builder Patch
@vercel/static-build Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/node/src/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@TooTallNate TooTallNate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changeset

@ecklf
Copy link
Member Author

ecklf commented Jun 2, 2023

Needs a changeset

Added a patch one, LMK if it should be minor.

cb1kenobi
cb1kenobi previously approved these changes Jun 2, 2023
Co-authored-by: Nathan Rajlich <n@n8.io>
Copy link
Contributor

@nuta nuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Left a nitpick.

'@vercel/node': minor
---

Add maxDuration config support for vc node deployments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nitpick: Can we replace [edge-compute] in the PR title with [node]? 🙏

@ecklf ecklf changed the title [edge-compute] add maxDuration config support for vc node deployments [node] add maxDuration config support for vc node deployments Jun 5, 2023
@ecklf
Copy link
Member Author

ecklf commented Jun 5, 2023

Merging because the requested change from Nate was applied.

@ecklf ecklf merged commit bc5afe2 into main Jun 5, 2023
102 checks passed
@ecklf ecklf deleted the ecklf/ec-977-add-support-for-vc-node-deployments branch June 5, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants