[cli] Add client.cwd to unify all working directory related logic
#10031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few commands were still checking on `--cwd` explicitly, which is incorrect since the entrypoint file already handles the directory change. The new `client.cwd` property is a helper to make writing tests easier. Tests no longer need to `chdir()` explicitly and then revert afterwards.
🦋 Changeset detectedLatest commit: 44523df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TooTallNate
requested review from
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
styfle
reviewed
May 26, 2023
cb1kenobi
reviewed
May 26, 2023
| } | ||
|
|
||
| set cwd(v: string) { | ||
| process.chdir(v); |
There was a problem hiding this comment.
This is brilliant, love it!
styfle
approved these changes
May 26, 2023
Merged
TooTallNate
added a commit
that referenced
this pull request
May 26, 2023
Follow-up to #10031 which broke the `link` unit tests on Windows. For some reason Kodiak was a bad bot and merged the PR with failing tests.
kodiakhq bot
pushed a commit
that referenced
this pull request
May 26, 2023
Follow-up to #10031 which broke the `link` unit tests on Windows. For some reason Kodiak was a bad bot and merged the PR with failing tests <picture data-single-emoji=":rarityannoyed:" title=":rarityannoyed:"><img class="emoji" src="https://emoji.slack-edge.com/T0CAQ00TU/rarityannoyed/b62f8c87a5fb7239.png" alt=":rarityannoyed:" width="20" height="auto" align="absmiddle"></picture> _Note:_ Probably easier to review with [whitespace hidden](https://github.com/vercel/vercel/pull/10033/files?w=1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few commands were still checking on
--cwdexplicitly, which is incorrect since the entrypoint file already handles the directory change.The new
client.cwdproperty is a helper to make writing tests easier. Tests no longer need tochdir()explicitly and then revert afterwards.