[node][edge][cli] upgrade Edge Runtime #10051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kikobeats
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
🦋 Changeset detectedLatest commit: 7ef5511 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
EndangeredMassa
previously approved these changes
Jun 1, 2023
|
When I tried this localy, it failed with: I updated the |
EndangeredMassa
previously approved these changes
Jun 1, 2023
Kikobeats
changed the title
undici.Websocket when is possible
EndangeredMassa
approved these changes
Jun 1, 2023
styfle
previously approved these changes
Jun 1, 2023
EndangeredMassa
requested changes
Jun 5, 2023
Kikobeats
commented
Jun 7, 2023
EndangeredMassa
changed the title
EndangeredMassa
previously approved these changes
Jun 7, 2023
cb1kenobi
previously approved these changes
Jun 7, 2023
Kikobeats
dismissed stale reviews from cb1kenobi and EndangeredMassa
via
0a3ff15
TooTallNate
approved these changes
Jun 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We avoided to use
undici.WebSocketbecause @jawj found a bug in the implementation.The fix was merged in undici@5.22.1, so we can be back to use it.
The latest version of Edge Runtime exposes
undici.WebSocketcompatible with node.js 14, 16 & 18