Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Fix pages and app router i18n handling #10243

Merged
merged 4 commits into from
Jul 24, 2023
Merged

[next] Fix pages and app router i18n handling #10243

merged 4 commits into from
Jul 24, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 24, 2023 •
edited by styfle

Ensures app router paths are handled properly when i18n is configured for pages directory.

x-ref: slack thread
x-ref: slack thread
x-ref: slack thread

VCCLI-780

@ijjk ijjk added area: next pr: automerge Automatically merge the PR when checks pass labels Jul 24, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023 •
edited

🦋 Changeset detected

Latest commit: e1d9554

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vercel/next Patch
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

styfle
styfle previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

styfle
styfle reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is failing:

Error: ENOENT: no such file or directory, open '/vercel/path1/.next/server/pages/404'

@ijjk ijjk requested a review from styfle July 24, 2023 21:39
styfle
styfle previously approved these changes Jul 24, 2023
View reviewed changes
styfle
styfle reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

● 00-middleware-base-path › should deploy and pass probe checks
  
      State of https://00-middleware-base-path-e4yopywpd-vtest314-wpdttjvuycahodexb099.vercel.app/ is ERROR: ENOENT: no such file or directory, open '/vercel/path1/.next/server/pages/docs/404.html'

@kodiakhq kodiakhq bot merged commit b1c14cd into main Jul 24, 2023
104 checks passed
@kodiakhq kodiakhq bot deleted the ijjk/fix-app-i18n branch July 24, 2023 23:26
@vercel-release-bot vercel-release-bot mentioned this pull request Jul 24, 2023
Merged
@leerob leerob mentioned this pull request Jul 25, 2023
Closed
1 task
TooTallNate pushed a commit that referenced this pull request Jul 25, 2023
@vercel-release-bot
Version Packages (#10227)
2661f56 
# Releases

## vercel@31.1.0

### Minor Changes

- Add 'Environment' column to 'vc list' with new '--environment' filter
and pipe URLs to stdout
([#10239](#10239))

### Patch Changes

- Update `proxy-agent` to v6.3.0
([#10226](#10226))

- Use `getNodeBinPaths()` in `vc dev`
([#10225](#10225))

- Updated dependencies
\[[`b1c14cde0`](b1c14cd),
[`ce4633fe4`](ce4633f)]:
    -   @vercel/next@3.9.1
    -   @vercel/static-build@1.3.42

## @vercel/frameworks@1.5.0

### Minor Changes

- Add `ignorePackageJsonScript` configuration for Framework command
settings to ignore the `package.json` script.
([#10228](#10228))

Enable this mode for Storybook's `buildCommand`, since it should not
invoke the "build" script, which is most likely designated for the
frontend app build.

## @vercel/fs-detectors@4.1.1

### Patch Changes

- Updated dependencies
\[[`ce4633fe4`](ce4633f)]:
    -   @vercel/frameworks@1.5.0

## @vercel/next@3.9.1

### Patch Changes

- Fix pages and app router i18n handling
([#10243](#10243))

## @vercel/static-build@1.3.42

### Patch Changes

- Add `ignorePackageJsonScript` configuration for Framework command
settings to ignore the `package.json` script.
([#10228](#10228))

Enable this mode for Storybook's `buildCommand`, since it should not
invoke the "build" script, which is most likely designated for the
frontend app build.
@tomihq
Copy link

tomihq commented Jul 25, 2023

Thanks!!!

@tomihq tomihq mentioned this pull request Jul 25, 2023
Open
@aralroca aralroca mentioned this pull request Jul 25, 2023
Open
@aralroca
Copy link

Thanks! 🎉

@LuizPelegrini
Copy link

Looks like CI is failing:

Error: ENOENT: no such file or directory, open '/vercel/path1/.next/server/pages/404'

@styfle my CI started failing with the exact error message you shared :(

@styfle
Copy link
Member

styfle commented Jul 25, 2023

@LuizPelegrini Likely because this PR hasn’t shipped to production yet. It should ship sometime today.

@LuizPelegrini
Copy link

LuizPelegrini commented Jul 25, 2023 •
edited

@styfle I'm confused, sorry. The latest release 31.1.0 states it uses @vercel/next@3.9.1 which includes this PR.

What do you mean it's not in production, yet? I thought once it's released, it's in production (apologies for dumb questions)

PS: Building locally also gives me this error. If I downgrade to vercel@31.0.4, CI and local builds work just fine 🤔

@Ayterx Ayterx mentioned this pull request Jul 25, 2023
Closed
1 task
@styfle
Copy link
Member

styfle commented Jul 25, 2023

Building locally also gives me this error. If I downgrade to vercel@31.0.4, CI and local builds work just fine

Is this using vercel build? Can you share the Next.js code to reproduce the issue?

@chozzz
Copy link

chozzz commented Aug 3, 2023

Any chance this might be related to vercel/next.js#53502?

@chozzz chozzz mentioned this pull request Aug 3, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@styfle styfle styfle approved these changes

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa EndangeredMassa is a code owner

@cb1kenobi cb1kenobi Awaiting requested review from cb1kenobi

@Ethan-Arrowood Ethan-Arrowood Awaiting requested review from Ethan-Arrowood Ethan-Arrowood is a code owner

Assignees
No one assigned
Labels
area: next pr: automerge Automatically merge the PR when checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ijjk @tomihq @aralroca @LuizPelegrini @styfle @chozzz @TooTallNate