Fix RSC prefetch for index route with catch-all #10734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi,
Ethan-Arrowood,
trek and
ztanner
as code owners
🦋 Changeset detectedLatest commit: 1f23c84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ethan-Arrowood
approved these changes
Oct 19, 2023
ijjk
commented
Oct 19, 2023
ztanner
approved these changes
Oct 19, 2023
Merged
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@32.5.0 ### Minor Changes - Indicates whether @vercel/speed-insights or @vercel/analytics are used ([#10623](#10623)) - [cli] update env var validation rule to allow name start with underscore ([#10697](#10697)) ### Patch Changes - Updated dependencies \[[`da300030c`](da30003), [`de84743e1`](de84743), [`913608de4`](913608d), [`7fa08088e`](7fa0808)]: - @vercel/next@4.0.11 - @vercel/python@4.1.0 - @vercel/remix-builder@2.0.10 - @vercel/redwood@2.0.5 - @vercel/static-build@2.0.9 ## @vercel/python@4.1.0 ### Minor Changes - Add support for pip3.10 and pip3.11 ([#10648](#10648)) ## @vercel/routing-utils@3.1.0 ### Minor Changes - Adds support for statusCode property on rewrites ([#10495](#10495)) ## @vercel/client@13.0.6 ### Patch Changes - Updated dependencies \[[`9e9fac019`](9e9fac0)]: - @vercel/routing-utils@3.1.0 ## @vercel/fs-detectors@5.1.2 ### Patch Changes - Updated dependencies \[[`9e9fac019`](9e9fac0)]: - @vercel/routing-utils@3.1.0 ## @vercel/gatsby-plugin-vercel-builder@2.0.8 ### Patch Changes - Updated dependencies \[[`9e9fac019`](9e9fac0)]: - @vercel/routing-utils@3.1.0 ## @vercel/next@4.0.11 ### Patch Changes - fix `build` in appDir on Windows ([#10708](#10708)) - Fix RSC prefetch for index route with catch-all ([#10734](#10734)) ## @vercel/redwood@2.0.5 ### Patch Changes - Updated dependencies \[[`9e9fac019`](9e9fac0)]: - @vercel/routing-utils@3.1.0 ## @vercel/remix-builder@2.0.10 ### Patch Changes - Update `@remix-run/dev` fork to v2.1.0 ([#10732](#10732)) ## @vercel/static-build@2.0.9 ### Patch Changes - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.8 ## @vercel-internals/types@1.0.13 ### Patch Changes - Updated dependencies \[[`9e9fac019`](9e9fac0)]: - @vercel/routing-utils@3.1.0
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
Follow-up to #10734 -- but considers that the static prefetch associated with `/` might be inside of a dir such as `index/index.prefetch.rsc`. To avoid any future matching conflicts, this PR updates to prefix all static prefetches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When matching outputs and we have an
index.{ext}file it will take priority over dynamic routes which we don't want to match prefetch RSC index outputs unless it's specifically a prefetch request so this remaps this specific file to avoid the overlap.x-ref: slack thread