Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli][client] Handle --repo linked in vc deploy --prebuilt #11309

Conversation

TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Mar 20, 2024

vc deploy --prebuilt has not properly worked for projects linked with vc link --repo ever since #11077.

To fix, don't mutate cwd to be the project subdir (so that cwd is always the monorepo root), and instead pass in a new property to @vercel/client that represents the .vercel/output file path. A lot of the code is just passing this new variable through the multiple layers of indirection in CLI before it finally reaches `@vercel/client.

Fixes #11097.

`vc deploy --prebuilt` has not properly worked for projects linked with
`vc link --repo` ever since #11077.

Fixes #11097.
Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 9b5c7e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vercel/client Patch
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@EndangeredMassa EndangeredMassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually tested this and it worked for me in a monorepo that was --repo linked

packages/client/src/utils/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Sean Massa <EndangeredMassa@gmail.com>
@EndangeredMassa
Copy link
Contributor

updated to include the CI fix from main

@TooTallNate TooTallNate added the pr: automerge Automatically merge the PR when checks pass label Mar 29, 2024
@TooTallNate TooTallNate merged commit 9a27ccb into main Mar 30, 2024
111 checks passed
@TooTallNate TooTallNate deleted the tootallnate/zero-1527-bug-we-should-look-into-vercel3330-broke-prebuilds-in branch March 30, 2024 00:23
onsclom pushed a commit that referenced this pull request Apr 3, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/build-utils@7.11.0

### Minor Changes

- Add `getOsRelease()` and `getProvidedRuntime()` functions
([#11370](#11370))

## @vercel/go@3.1.0

### Minor Changes

- Use `provided.al2023` runtime when using AL2023 build image
([#11370](#11370))

## vercel@33.6.3

### Patch Changes

- Handle `--repo` linked in `vc deploy --prebuilt`
([#11309](#11309))

- Revert "[cli] extract `isZeroConfigBuild` into utility function
(#11316)" ([#11350](#11350))

- Replace `inquirer` with `@inquirer/prompts`
([#11321](#11321))

- Updated dependencies
\[[`73b112b1f`](73b112b),
[`346e665bb`](346e665),
[`73b112b1f`](73b112b),
[`548afd371`](548afd3)]:
    -   @vercel/go@3.1.0
    -   @vercel/node@3.0.26
    -   @vercel/build-utils@7.11.0
    -   @vercel/static-build@2.4.6

## @vercel/client@13.1.9

### Patch Changes

- Handle `--repo` linked in `vc deploy --prebuilt`
([#11309](#11309))

- Updated dependencies
\[[`73b112b1f`](73b112b)]:
    -   @vercel/build-utils@7.11.0

## @vercel/gatsby-plugin-vercel-builder@2.0.24

### Patch Changes

- Updated dependencies
\[[`73b112b1f`](73b112b)]:
    -   @vercel/build-utils@7.11.0

## @vercel/node@3.0.26

### Patch Changes

- Fix issue with serverless function on docker
([#11226](#11226))

- Add import and require ts-node files for TypeScript in `vc dev`
([#11371](#11371))

- Updated dependencies
\[[`73b112b1f`](73b112b)]:
    -   @vercel/build-utils@7.11.0

## @vercel/static-build@2.4.6

### Patch Changes

-   Updated dependencies \[]:
    -   @vercel/gatsby-plugin-vercel-builder@2.0.24

## @vercel-internals/types@1.0.29

### Patch Changes

- Updated dependencies
\[[`73b112b1f`](73b112b)]:
    -   @vercel/build-utils@7.11.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Automatically merge the PR when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vercel@33.3.0 broke preBuilds in monorepo
3 participants