Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[static-build] Fix running of e2e tests #11518

Merged
merged 5 commits into from Apr 30, 2024
Merged

[static-build] Fix running of e2e tests #11518

merged 5 commits into from Apr 30, 2024

Conversation

TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Apr 30, 2024

We accidentally committed a change which prevented the static-build e2e tests, so fixing that.

Also reverting a change from #11497 which was causing issues with Ruby-based static site generators when using the AL2 build image.

Copy link

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: ac02a3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TooTallNate TooTallNate changed the title [static-build] Revert SUPPORTED_RUBY_VERSION change [static-build] Fix running of e2e tests Apr 30, 2024
TooTallNate pushed a commit that referenced this pull request Apr 30, 2024
…-build/test/fixtures/hydrogen-v2023 with 6 updates" (#11521)

Reverts #11480

This was merged in when we weren't running the tests.
([Fix](#11518)).
@TooTallNate TooTallNate marked this pull request as ready for review April 30, 2024 19:35
@TooTallNate TooTallNate added the pr: automerge Automatically merge the PR when checks pass label Apr 30, 2024
@TooTallNate TooTallNate merged commit f11c702 into main Apr 30, 2024
110 checks passed
@TooTallNate TooTallNate deleted the ruby-static-build branch April 30, 2024 19:57
TooTallNate added a commit that referenced this pull request Apr 30, 2024
)

A changeset should have been included for
#11518. Adding that here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Automatically merge the PR when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants