Fix/Prevent erounus Next.js API route warning, on non-Next.js apps #11611
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an issue where developers receive misleading warnings about the placement of API files in non-Next.js projects hosted on Vercel.
The current logic triggers a warning when any file under the
pages/
directory loosely starts withpages/api
, which could include unrelated directories likepages/api-docs
. This results in unnecessary confusion for developers not using Next.js for their project.Changes
Updates the if statement in
hasNextApiFiles
to strictly check for files withinpages/api/
orsrc/pages/api/
, and NOT file names which just happen to start with the wordapi-
. I also added a check to ensure that warnings related to Next.js API file placement are only shown if the project is indeed using Next.js.Links
Fixes #11696