[tests] refactor dev utils to typescript #11646
Open
+170
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e22249 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
EndangeredMassa
requested review from
TooTallNate,
trek,
onsclom,
jeffsee55 and
erikareads
as code owners
trek
approved these changes
May 23, 2024
|
The dev tests didn't run. They were FULL TURBO. Need to figure out how to make those run when dev utils changes. |
|
@EndangeredMassa these ran, oddly https://github.com/vercel/vercel/actions/runs/9213216512/job/25346689041?pr=11646 to the tune of 7 minutes. Weird. |
TooTallNate
approved these changes
May 25, 2024
onsclom
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
packages/cli/test/dev/utils.jsto typescript to make it easier to work with.