Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added waiting message to various commands that perform I/O #1204

Conversation

riddla
Copy link
Contributor

@riddla riddla commented Mar 19, 2018

Refs #807, #1167

  • moved waiting message from list command to util class
  • now alias ls
  • now alias rm
  • In the Now util class:
    • listAliases
    • listSecrets
    • list
    • listInstances
    • logs
    • listDomains
    • getDomain
    • [...]

Refs vercel#807, vercel#1167

* `now alias ls`
* `now alias rm`
* In the `Now` util class:
	* `listAliases`
	* `listSecrets`
	* `list`
	* `listInstances`
	* `logs`
	* `listDomains`
	* `getDomain`
	* [...]
@riddla
Copy link
Contributor Author

riddla commented Mar 19, 2018

While working on the util/index.js I wondered if the various waiting (and error?) messages should be encapsulated somewhere. Lookup table within the same or another file? Or a more general purposed module that holds the various message strings and makes them easy to edit and maybe align in one place?

@rauchg
Copy link
Member

rauchg commented Apr 10, 2018

@riddla we indeed went with that approach. Please take a look at certs.js or alias.js for an example of how we want to do logging and error-handling moving forward.

We want to deprecate util/index.js altogether, but we are doing so incrementally.

I'm closing this PR as the codebase has diverged quite a bit. But feel free to submit a similar PR against, for example, now dns, which we haven't gotten around to refactoring quite yet.

Much appreciated 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants