Replaced the update checker #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javivelasco
approved these changes
Apr 9, 2018
leo
added a commit
that referenced
this pull request
Apr 9, 2018
* Replaced update checker * Moved to devDeps * Removed prod dep entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we've noticed that some customers weren't seeing the update message when there was actually a new version out.
This was due to our previous update checker having a lot of error surface by spawning a child process that could potentially get lost.
In turn, we moved to a self-built one that blocks the command execution for a few hundred milliseconds every day to ensure the user is really running the latest version. If not, a beautiful update message is displayed: