Allow to deploy and alias when non essential APIs are down #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo
pushed a commit
that referenced
this pull request
Jul 3, 2018
* Try to purchase a domain only when there is no other choice * Allow eventsStream to fail during deployment * Allow to verify instantiation without events API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes:
In
aliaswe were trying to purchase a domain by checking if it was available right when we started alias. In case the API was down the CLI would fail, no matter the domain you were aliasing. Now, we only try to purchase the domain in two of the following scenarios:In
deploywe were trying to get the events stream to both log the events and to verify instantiation in DCs define by the deployment parameters. If the deployment events API is down, the deployments wouldn't work. Now, getting the events stream is optional so in case the API doesn't work we will try to figure out when the deployment is ready by only polling the deployment state. With a similar approach, verification would be performed only withverifyDeploymentScalewhen the stream isnull.