Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"now domains transfer-in" support #1767

Merged
merged 9 commits into from
Jan 22, 2019
Merged

"now domains transfer-in" support #1767

merged 9 commits into from
Jan 22, 2019

Conversation

mglagola
Copy link
Member

@mglagola mglagola commented Dec 20, 2018

Support for now domains transfer-in <domain-name>.com

@mglagola mglagola changed the title WIP: "now domains transfer-in" support "now domains transfer-in" support Jan 21, 2019
@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #1767 into canary will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #1767      +/-   ##
=========================================
+ Coverage    6.16%   6.34%   +0.18%     
=========================================
  Files          94      93       -1     
  Lines        4170    4049     -121     
=========================================
  Hits          257     257              
+ Misses       3913    3792     -121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24182d...8ca4155. Read the comment docs.

Copy link
Member

@javivelasco javivelasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

I've left a few comments

src/commands/domains/index.ts Outdated Show resolved Hide resolved
src/commands/domains/index.ts Outdated Show resolved Hide resolved
src/commands/domains/index.ts Outdated Show resolved Hide resolved
src/commands/domains/transfer-in.ts Outdated Show resolved Hide resolved
src/commands/domains/transfer-in.ts Outdated Show resolved Hide resolved
src/commands/domains/transfer-in.ts Outdated Show resolved Hide resolved
src/commands/domains/transfer-in.ts Outdated Show resolved Hide resolved
src/commands/domains/transfer-in.ts Outdated Show resolved Hide resolved
src/util/domains/transfer-in-domain.ts Show resolved Hide resolved
src/util/input/text.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@javivelasco javivelasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@mglagola mglagola merged commit 31bfaa0 into vercel:canary Jan 22, 2019
@mglagola mglagola deleted the add/transfer-in branch January 22, 2019 23:31
@berkant
Copy link

berkant commented Jan 24, 2019

Guys when custom NS option is coming for domains bought in Now?

@javivelasco
Copy link
Member

Pretty soon, we'll be working on it during the following days

leo pushed a commit that referenced this pull request Feb 1, 2019
leo pushed a commit that referenced this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants