Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run prettier for JS/TS files #1791

Merged
merged 2 commits into from Jan 3, 2019
Merged

Only run prettier for JS/TS files #1791

merged 2 commits into from Jan 3, 2019

Conversation

leo
Copy link
Contributor

@leo leo commented Jan 3, 2019

Like this, we ensure to only pass modified JS/TS files to prettier.

@leo leo added the enhancement label Jan 3, 2019
@leo leo requested a review from javivelasco January 3, 2019 17:07
@codecov-io
Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #1791 into canary will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           canary   #1791   +/-   ##
======================================
  Coverage    78.7%   78.7%           
======================================
  Files           6       6           
  Lines         263     263           
======================================
  Hits          207     207           
  Misses         56      56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655bce7...ae957c5. Read the comment docs.

@leo leo changed the title Only run prettier for JS files Only run prettier for JS/TS files Jan 3, 2019
@leo leo merged commit 299452e into canary Jan 3, 2019
@leo leo deleted the hook branch January 3, 2019 19:07
javivelasco added a commit that referenced this pull request Jan 4, 2019
* canary:
  Only run prettier for JS/TS files (#1791)
leo added a commit that referenced this pull request Jan 4, 2019
* Only pass modified js files

* Look for TS too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants