Improved test suite #1820
Merged
Improved test suite #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #1820 +/- ##
==========================================
- Coverage 77.52% 5.81% -71.72%
==========================================
Files 6 100 +94
Lines 267 4247 +3980
==========================================
+ Hits 207 247 +40
- Misses 60 4000 +3940
Continue to review full report at Codecov.
|
AndyBitz
approved these changes
Jan 14, 2019
leo
added a commit
that referenced
this pull request
Jan 15, 2019
* Bumped `@zeit/ncc` to latest * Reverted lockfile * Make linking build for dev * Cover line 21 in util/config/local-path.js * Heavily improved unit test coverage * Fixed space * Got to 90% coverage * Removed useless code * Made builds work * Fixed a few lines * Fully covered read-metadata.js * Brought coverage to 95.38 * Removed code that was never executed * Track everything * Don't show badge for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally makes
nyctrack all the source files for code coverage and adds many new unit tests in order to bring the coverage up.Furthermore, it removes the following code paths that were never executed at all:
whitelistand this check already captures all the properties that were checked for down below)nowConfigmatchpkg.nowif it is set)