Added default script that will run if now fails to install #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndyBitz Please publish this under a different npm package name and test installation there. |
rauchg
reviewed
Jan 16, 2019
Codecov Report
@@ Coverage Diff @@
## canary #1832 +/- ##
======================================
Coverage 6.14% 6.14%
======================================
Files 94 94
Lines 4168 4168
======================================
Hits 256 256
Misses 3912 3912Continue to review full report at Codecov.
|
leo
approved these changes
Jan 21, 2019
leo
pushed a commit
that referenced
this pull request
Feb 1, 2019
* Added default script that will run if now fails to install * Don't overwrite the default now script before publishing * Copy the default now binary on publish instead of keeping it inside the dist folder * Removed download/dist/now * Changed text
leo
pushed a commit
that referenced
this pull request
Feb 14, 2019
* Added default script that will run if now fails to install * Don't overwrite the default now script before publishing * Copy the default now binary on publish instead of keeping it inside the dist folder * Removed download/dist/now * Changed text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Now CLI should fail to install this default script will be run instead.
It tells the user that
ignore-scriptsshould befalsewhile installing.