Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the --target flag #1893

Merged
merged 5 commits into from
Feb 27, 2019
Merged

Added support for the --target flag #1893

merged 5 commits into from
Feb 27, 2019

Conversation

AndyBitz
Copy link
Contributor

@AndyBitz AndyBitz commented Feb 15, 2019

This will add support for the --target flag as soon as it launches.

Example output:

• date-test $ cat now.json 
{
 "version": 2,
 "builds": [
  { "src": "date.js", "use": "@now/node" }
 ],
 "alias": "now-test-alias-for-production-00000000001.now.sh"
}
• date-test $ node ../now-cli/dist/index.js
> Deploying ~/projects/zeit/date-test under so-noice-right
> Using project date-test
> Synced 1 file (140B) [1s]
> https://date-test-kngwl37q2.now.sh [v2] [in clipboard] [3s]
┌ date.js        Ready               [21s]
└── λ date.js (1.97KB) [bru1]
> Success! Your deployment is now available on artzbitz-date-test.so-noice-right.now.sh [1m]
• date-test $ node ../now-cli/dist/index.js --target production
> Deploying ~/projects/zeit/date-test under so-noice-right
> Using project date-test
> https://date-test-gh3mce6d0.now.sh [v2] [in clipboard] [4s]
┌ date.js        Ready               [22s]
└── λ date.js (1.97KB) [bru1]
> Success! Your deployment is now available on now-test-alias-for-production-00000000001.now.sh and artzbitz-date-test.so-noice-right.now.sh [28s]
• date-test $ 

@AndyBitz AndyBitz requested a review from leo February 15, 2019 19:10
@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #1893 into canary will decrease coverage by 0.31%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #1893      +/-   ##
=========================================
- Coverage    6.64%   6.33%   -0.32%     
=========================================
  Files          93      91       -2     
  Lines        4048    4058      +10     
=========================================
- Hits          269     257      -12     
- Misses       3779    3801      +22
Impacted Files Coverage Δ
src/commands/deploy/args.js 0% <ø> (ø) ⬆️
src/commands/deploy/latest.js 0% <0%> (ø) ⬆️
src/util/index.js 0% <0%> (ø) ⬆️
src/util/get-project-name.js 90.9% <0%> (-9.1%) ⬇️
src/util/get-files.js 91.53% <0%> (-8.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69c0fd...7f9d471. Read the comment docs.

src/commands/deploy/latest.js Outdated Show resolved Hide resolved
src/commands/deploy/latest.js Outdated Show resolved Hide resolved
@leo leo changed the title Add support for the target flag Added support for the --target flag Feb 26, 2019
@AndyBitz AndyBitz merged commit aea9bd4 into canary Feb 27, 2019
@AndyBitz AndyBitz deleted the add-target branch February 27, 2019 18:33
leo pushed a commit that referenced this pull request Mar 18, 2019
* Add support for the target flag

* Show the given alias at the end

* Use the proper naming for the alias properies and include arrays

* Use the correct output

* Make sure that aliasFinal has properties
leo added a commit that referenced this pull request Mar 18, 2019
leo pushed a commit that referenced this pull request Mar 19, 2019
* Add support for the target flag

* Show the given alias at the end

* Use the proper naming for the alias properies and include arrays

* Use the correct output

* Make sure that aliasFinal has properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants