New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to copy symlinks #191
Conversation
@@ -90,6 +92,7 @@ const help = () => { | |||
-f, --force Force a new deployment even if nothing has changed | |||
-t ${chalk.underline('TOKEN')}, --token=${chalk.underline('TOKEN')} Login token | |||
-L, --login Configure login | |||
-l, --links Copy symlinks as symlinks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this a little more explicit:
Don't resolve symlinks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add an option to ignore permissions or file mode completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it actually not resolving symlinks ? I do agree that it needs re-wording, but not sure it's that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw. that's the same wording as rsync is using 🙂
What's the spirit of this option? |
@rauchg Currently it's not possible to use symlinks (with now-cli) in deployments because we always copy the contents of the file. So if you have a symlink to a file you just get two copies of the file inside the deployment instead of a symlink. With this option the user can opt-in for real symlinks. |
No description provided.