Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to copy symlinks #191

Merged
merged 1 commit into from Dec 30, 2016
Merged

Add an option to copy symlinks #191

merged 1 commit into from Dec 30, 2016

Conversation

OlliV
Copy link
Contributor

@OlliV OlliV commented Dec 29, 2016

No description provided.

@OlliV OlliV requested review from rauchg and leo December 29, 2016 21:19
@@ -90,6 +92,7 @@ const help = () => {
-f, --force Force a new deployment even if nothing has changed
-t ${chalk.underline('TOKEN')}, --token=${chalk.underline('TOKEN')} Login token
-L, --login Configure login
-l, --links Copy symlinks as symlinks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this a little more explicit:

Don't resolve symlinks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add an option to ignore permissions or file mode completely?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it actually not resolving symlinks ? I do agree that it needs re-wording, but not sure it's that one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw. that's the same wording as rsync is using 🙂

@rauchg
Copy link
Member

rauchg commented Dec 29, 2016

What's the spirit of this option?

@OlliV
Copy link
Contributor Author

OlliV commented Dec 30, 2016

@rauchg Currently it's not possible to use symlinks (with now-cli) in deployments because we always copy the contents of the file. So if you have a symlink to a file you just get two copies of the file inside the deployment instead of a symlink. With this option the user can opt-in for real symlinks.

@leo leo merged commit 1c7a13f into master Dec 30, 2016
@leo leo deleted the symlinks branch December 30, 2016 17:44
TooTallNate pushed a commit that referenced this pull request Aug 23, 2019
* Fix docstrings, remove unused rust dev dependency

* Add support for multiple binaries, prepareCache too

* Remove context from the handler signature, abstract over the AWS error

* Fix Rust tarball URL, caching and lint

* GCC URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants