Fix the handling of user errors #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliangruber
commented
Mar 13, 2019
Codecov Report
@@ Coverage Diff @@
## canary #1959 +/- ##
=========================================
- Coverage 6.57% 6.3% -0.27%
=========================================
Files 90 90
Lines 4092 4092
=========================================
- Hits 269 258 -11
- Misses 3823 3834 +11
Continue to review full report at Codecov.
|
juliangruber
changed the title
size_limit_exceeded
juliangruber
commented
Mar 14, 2019
| super({ | ||
| code: 'DEPLOYMENT_TYPE_UNSUPPORTED', | ||
| meta: {}, | ||
| message: `This region only accepts Serverless Docker Deployments` |
There was a problem hiding this comment.
is that always the case with this error?
There was a problem hiding this comment.
@juliangruber I think we should say that only Now 2.0 deployments are supported?
juliangruber
changed the title
leo
suggested changes
Mar 14, 2019
leo
approved these changes
Mar 15, 2019
leo
pushed a commit
that referenced
this pull request
Mar 18, 2019
* fix unexpected `size_limit_exceeded` * fix unexpected `deployment_type_unsupported` * fix unexpected `JSONError` * check if err.sizeLimit exists
leo
pushed a commit
that referenced
this pull request
Mar 19, 2019
* fix unexpected `size_limit_exceeded` * fix unexpected `deployment_type_unsupported` * fix unexpected `JSONError` * check if err.sizeLimit exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.