Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the DomainNotVerified error for deployments #1973

Merged
merged 1 commit into from
Mar 16, 2019

Conversation

AndyBitz
Copy link
Contributor

@AndyBitz AndyBitz commented Mar 16, 2019

This handles the domain_not_verified error from deployments when used with --target production.

The output will look like this:

> Deploying ~/projects/zeit/date-test under artzbitz
> Using project date-test
> Error! The domain amazon.com (defined in `alias`) is not verified yet. Please verify it and try again.

@leo leo self-requested a review March 16, 2019 17:51
src/commands/deploy/latest.js Show resolved Hide resolved
@AndyBitz AndyBitz requested a review from leo March 16, 2019 17:54
@codecov-io
Copy link

Codecov Report

Merging #1973 into canary will decrease coverage by 0.29%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           canary   #1973     +/-   ##
========================================
- Coverage    6.53%   6.23%   -0.3%     
========================================
  Files          90      90             
  Lines        4115    4120      +5     
========================================
- Hits          269     257     -12     
- Misses       3846    3863     +17
Impacted Files Coverage Δ
src/commands/deploy/latest.js 0% <0%> (ø) ⬆️
src/util/deploy/create-deploy.js 0% <0%> (ø) ⬆️
src/util/get-project-name.js 90.9% <0%> (-9.1%) ⬇️
src/util/get-files.js 91.53% <0%> (-8.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3145b0...01a119c. Read the comment docs.

@leo leo merged commit 2b3ceba into canary Mar 16, 2019
@leo leo deleted the domain-verification-error branch March 16, 2019 18:04
leo added a commit that referenced this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants