Add always report stdarg to Sentry #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, only if `user` or `team` could be read from the scope would stdarg be reported to Sentry, however it's completely unrelated to the existence of the former and is always useful debugging information.
Codecov Report
@@ Coverage Diff @@
## canary #1982 +/- ##
=========================================
+ Coverage 6.27% 6.27% +<.01%
=========================================
Files 90 90
Lines 4113 4111 -2
=========================================
Hits 258 258
+ Misses 3855 3853 -2
Continue to review full report at Codecov.
|
leo
pushed a commit
that referenced
this pull request
Mar 19, 2019
Before this change, only if `user` or `team` could be read from the scope would stdarg be reported to Sentry, however it's completely unrelated to the existence of the former and is always useful debugging information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, only if
userorteamcould be read from the scope would stdarg be reported to Sentry, however it's completely unrelated to the existence of the former and is always useful debugging information.