[now dev] Fix subscription resolving logic #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strip the leading `/` since the builder outputs don't have one, match index routes, and pass the resulting subscription key to the builder.
Codecov Report
@@ Coverage Diff @@
## canary #2082 +/- ##
=========================================
- Coverage 4.63% 4.5% -0.13%
=========================================
Files 243 243
Lines 8572 8575 +3
Branches 873 876 +3
=========================================
- Hits 397 386 -11
- Misses 8158 8172 +14
Partials 17 17
Continue to review full report at Codecov.
|
dav-is
approved these changes
Apr 4, 2019
leo
pushed a commit
that referenced
this pull request
Apr 5, 2019
* [now dev] Fix subscription resolving logic Strip the leading `/` since the builder outputs don't have one, match index routes, and pass the resulting subscription key to the builder. * Fix `index` matching * Update `@now/build-utils` to v0.4.39-canary.0 * Update `@now/build-utils` to v0.4.39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip the leading
/since the builder outputs don't have one, matchindex routes, and pass the resulting subscription key to the builder.