[now dev] Use a different workPath for every build
#2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more inline with how a fresh Now deployment works, where is has to download fresh files each time. This will also fix the issue with `@now/next` that deleted the `.next` output dir and deleting static files upon subsequent builds. This is still a bit unoptimized because `prepareCache()` from the builder is not yet being invoked, but it's still more correct than reusing the `workPath`.
leo
approved these changes
Apr 5, 2019
Timer
approved these changes
Apr 5, 2019
leo
pushed a commit
that referenced
this pull request
Apr 5, 2019
This is more inline with how a fresh Now deployment works, where is has to download fresh files each time. This will also fix the issue with `@now/next` that deleted the `.next` output dir and deleting static files upon subsequent builds. This is still a bit unoptimized because `prepareCache()` from the builder is not yet being invoked, but it's still more correct than reusing the `workPath`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more inline with how a fresh Now deployment works, where is has to download fresh files each time. This will also fix the issue with
@now/nextthat deleted the.nextoutput dir and deleting static files upon subsequent builds.This is still a bit unoptimized because
prepareCache()from the builder is not yet being invoked, but it's still more correct than reusing theworkPath.