Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now dev] Fix index-based asset lookup logic #2138

Merged
merged 1 commit into from Apr 12, 2019

Conversation

TooTallNate
Copy link
Member

There was a bug in the index lookup logic such that GET /404 would be matching the /index.* file. Fixed in this PR.

There was a bug in the index lookup logic such that `GET /404` would be
matching the `/index.*` file. Fixed in this commit.
@codecov-io
Copy link

Codecov Report

Merging #2138 into canary will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #2138      +/-   ##
=========================================
- Coverage    4.44%   4.43%   -0.01%     
=========================================
  Files         243     243              
  Lines        8648    8652       +4     
  Branches      901     902       +1     
=========================================
  Hits          384     384              
- Misses       8247    8251       +4     
  Partials       17      17
Impacted Files Coverage Δ
src/commands/dev/lib/dev-server.ts 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f74a06...f322896. Read the comment docs.

@TooTallNate TooTallNate merged commit 2dfd4e8 into canary Apr 12, 2019
@TooTallNate TooTallNate deleted the fix/now-dev-index-match-asset-lookup-edge-case branch April 12, 2019 01:50
leo pushed a commit that referenced this pull request Apr 25, 2019
There was a bug in the index lookup logic such that `GET /404` would be
matching the `/index.*` file. Fixed in this commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants