Added file watcher to `now dev` #2153

TooTallNate · 2019-04-12T22:18:30Z

This PR is for triggering background rebuilds. So far the files mapping is now kept in sync via the events produced by nsfw.

WIP for triggering background rebuilds. So far the `files` mapping is now kept in sync via the events produced by `nsfw`.

codecov-io · 2019-04-12T22:26:41Z

Codecov Report

Merging #2153 into canary will decrease coverage by 0.07%.
The diff coverage is 1.03%.

@@            Coverage Diff            @@
##           canary   #2153      +/-   ##
=========================================
- Coverage    4.43%   4.36%   -0.08%     
=========================================
  Files         243     244       +1     
  Lines        8652    8793     +141     
  Branches      902     923      +21     
=========================================
  Hits          384     384              
- Misses       8251    8392     +141     
  Partials       17      17

Impacted Files	Coverage Δ
src/commands/dev/lib/types.ts	`0% <ø> (ø)`	⬆️
src/commands/dev/lib/dev-builder.ts	`0% <0%> (ø)`	⬆️
src/commands/dev/lib/dev-server.ts	`0% <0%> (ø)`	⬆️
src/commands/dev/lib/nsfw-module.ts	`0% <0%> (ø)`
src/commands/dev/lib/static-builder.ts	`0% <0%> (ø)`	⬆️
src/commands/dev/lib/builder-cache.ts	`0% <0%> (ø)`	⬆️
src/commands/dev/lib/dev-router.ts	`72% <100%> (ø)`	⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 614b9c4...ae23d00. Read the comment docs.

src/commands/dev/lib/dev-server.ts

@types/nsfw/index.d.ts

src/commands/dev/lib/dev-server.ts

amio

We also need a live ignore filter, filter out our default IGNORES, and gets updated with .nowignore file change. But we can do this in another PR.

TooTallNate · 2019-04-14T02:02:43Z

@leo This PR is more or less ready, except that we still need to figure out how to handle the nsfw.node binary file in our build process to make it work properly with pkg.

I suggest we fork nsfw and make it require the .node file from a temporary location, which now-cli would copy from it's snapshot filesystem to the temporary location before requiring nsfw.

amio · 2019-04-15T03:12:38Z

@TooTallNate Looks like we just put nsfw.node by the side of dist/index.js then it should be fine 🤔

> Warning Cannot include addon %1 into executable.
  The addon must be distributed with executable as %2.
  /Users/xilo/git/zeit/now-cli/dist/build/Release/nsfw.node
  path-to-executable/nsfw.node

leo · 2019-04-15T12:58:40Z

@amio The problem is not the bundling, it's the fact that nsfw then ready from the virtual file system inside pkg without being able to access the paths to watch on the real file system.

I'm working on it today.

.circleci/config.yml

This reverts commit 0b4991b.

src/commands/dev/lib/nsfw-module.ts

styfle · 2019-04-16T15:28:03Z

src/commands/dev/lib/dev-builder.ts

-      // `BuilderOutputs` map was returned
-      result = { output: result as BuilderOutputs };
+    if (r.output) {
+      result = r as BuildResult;


So this why returning a version would be good because then you wouldn't need to cast. Oh well 🤷‍♂️

Co-Authored-By: leo <mindrun@icloud.com>

* [now dev] Add `nsfw` file watcher WIP for triggering background rebuilds. So far the `files` mapping is now kept in sync via the events produced by `nsfw`. * Add `now.json` caching and invalidation from nsfw events * Add initial rebuilding logic from filesystem watching * Remove previously built assets when a rebuild occurs * Make `@now/static` not require a hard refresh * Shut down the `nsfw` instance when stopping the DevServer * Prettier and some minor tweaks * Ship module * Support private deps * Fixed tests * Fixed integration tests * Revert "Support private deps" This reverts commit 0b4991b. * Support multiple platforms * Typed * Consider Alpine * Bumped @zeit/nsfw to latest version * Update src/commands/dev/lib/nsfw-module.ts Co-Authored-By: leo <mindrun@icloud.com> * Pass module path differently * Bumped package * Make binary executable * Wait until piping is complete * Added debug statements

[now dev] Add nsfw file watcher

4c5fb22

WIP for triggering background rebuilds. So far the `files` mapping is now kept in sync via the events produced by `nsfw`.

TooTallNate changed the title ~~[now dev] Add nsfw file watcher~~ [now dev] WIP Add nsfw file watcher Apr 12, 2019

TooTallNate requested review from amio, styfle and leo April 12, 2019 22:18

Add now.json caching and invalidation from nsfw events

3c04d62