Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print stopping server if already printed URL #2249

Merged
merged 1 commit into from Apr 27, 2019
Merged

Only print stopping server if already printed URL #2249

merged 1 commit into from Apr 27, 2019

Conversation

leo
Copy link
Contributor

@leo leo commented Apr 27, 2019

This ensures we only print this message if we already printed the server URL:

image

It also prints a nice newline to make it look better:

image

@codecov-io
Copy link

Codecov Report

Merging #2249 into canary will increase coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2249      +/-   ##
==========================================
+ Coverage   10.38%   10.41%   +0.02%     
==========================================
  Files         246      246              
  Lines        9030     9037       +7     
  Branches      986      988       +2     
==========================================
+ Hits          938      941       +3     
- Misses       7972     7975       +3     
- Partials      120      121       +1
Impacted Files Coverage Δ
src/commands/dev/lib/dev-server.ts 39.65% <77.77%> (+0.2%) ⬆️
src/commands/dev/lib/builder-cache.ts 65.57% <0%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9029a51...442bbc7. Read the comment docs.

Copy link
Contributor

@thasophearak thasophearak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@leo leo merged commit 1aa4671 into canary Apr 27, 2019
@leo leo deleted the stop-server branch April 27, 2019 13:40
@leo leo restored the stop-server branch April 27, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants