Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now dev] Fix directory listing #2256

Merged
merged 2 commits into from Apr 28, 2019
Merged

[now dev] Fix directory listing #2256

merged 2 commits into from Apr 28, 2019

Conversation

amio
Copy link
Contributor

@amio amio commented Apr 28, 2019

Treat a project as static deployment if now.json match one of these:

  • no builds
  • all builds have @now/static as use

@amio amio requested review from TooTallNate and leo April 28, 2019 14:59
@leo
Copy link
Contributor

leo commented Apr 28, 2019

Works!

BEFORE

Screenshot 2019-04-28 at 17 08 58

AFTER

Screenshot 2019-04-28 at 17 09 22

@leo leo changed the title [now dev] fix directory listing [now dev] Fix directory listing Apr 28, 2019
@leo leo removed the request for review from TooTallNate April 28, 2019 15:36
@codecov-io
Copy link

Codecov Report

Merging #2256 into canary will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2256      +/-   ##
==========================================
+ Coverage   10.43%   10.45%   +0.01%     
==========================================
  Files         246      246              
  Lines        9024     9040      +16     
  Branches      990      994       +4     
==========================================
+ Hits          942      945       +3     
- Misses       7958     7968      +10     
- Partials      124      127       +3
Impacted Files Coverage Δ
src/commands/dev/lib/dev-server.ts 38.82% <100%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf846e...eb84fb0. Read the comment docs.

@leo leo merged commit 91069f6 into canary Apr 28, 2019
@leo leo deleted the fix/directory-listing branch April 28, 2019 15:50
leo pushed a commit that referenced this pull request Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants